Attention is currently required from: pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31341 )

Change subject: pcu_l1_if_phy: flexible phy access ......................................................................

Patch Set 8:

(2 comments)

File src/osmobts_sock.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/e88a4bad_0a0ff8b0 PS5, Line 115: bts->trx[trx].fl1h = NULL;

If you want to make it mandatory for any driver to implement that function then yes it's fine

One could argue if there may be a driver in the future that does not require to be closed but I think this is mandatory. At least at the moment all drivers implement such a function.

File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/bc5b8af9_e09cf835 PS5, Line 218: the_pcu->phy_ops->l1if_pdch_req(bts->trx[trx].fl1h, ts, 0, fn, arfcn, block_nr,

Again, this makes this function mandatory to be implemented by the driver.

l1if_pdch_req() is an integral part of the driver concept, its definitely needed by every driver.