Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36148?usp=email ) Change subject: stp: add and use f_m3ua_{cli,srv}_config() helpers ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36148/comment/97b5e5fb_99aa… PS1, Line 110: mtc.stop; I never liked doing it this way. The benefit of writing one long line doing several things in one go is questionable, especially when you need to log some values and thus have to use `log2str()`. We are not limited by the number of code lines, so I prefer using `setverdict()` explicitly, rather than hiding it behind the scenes of overloaded functions like `f_shutdown()`. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36148?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9788f52c20574f4f9d015d2de11b5e42bb03d15f Gerrit-Change-Number: 36148 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Mar 2024 08:50:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment