Attention is currently required from: daniel, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email )
Change subject: Refactor diffing same GMM messages
......................................................................
Patch Set 12:
(1 comment)
This change is ready for review.
File src/sgsn/gprs_gmm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37867/comment/e47231a3_13603203?us… :
PS8, Line 1447: return memcmp(gh_a, gh_b, msgb_l3len(a));
This function can now return -1 if the lengths
don't match OR if the msgs are unequal (and memcmp re […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie698d3a6894a5796663c22c8bfd12b47acda57e6
Gerrit-Change-Number: 37867
Gerrit-PatchSet: 12
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Sep 2024 15:37:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>