csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email ) Change subject: nokia_site: add object_type, object_state and reset_type ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hi Pau, The only warning Jenkins gave is that the newly added functions are not used. Which is correct as this commit only adds these elements, related functions are coming later. What should I do? Keep it like this and then this can be reviewed and merged, or I can also revoke this commit and add everything together later. Although I think it is better to keep these patches small and separate. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f31cd711768c963e5c14c0f4969ff76cb05c12b Gerrit-Change-Number: 39315 Gerrit-PatchSet: 1 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 15:13:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No