laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37139?usp=email ) Change subject: pySim/ota: Don't modify input argument in OtaDialectSms.encode_cmd ...................................................................... pySim/ota: Don't modify input argument in OtaDialectSms.encode_cmd Change-Id: I4c4c44002762696b931ed3580ffe54daf62ffa61 --- M pySim/ota.py 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/ota.py b/pySim/ota.py index 10de611..54e8f75 100644 --- a/pySim/ota.py +++ b/pySim/ota.py @@ -332,6 +332,7 @@ len_cipher = 6 + len_sig + len(apdu) padding = otak.crypt._get_padding(len_cipher, otak.crypt.blocksize) pad_cnt = len(padding) + apdu = bytes(apdu) # make a copy so we don't modify the input data apdu += padding kic = {'key': otak.kic_idx, 'algo': otak.algo_crypt} -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4c4c44002762696b931ed3580ffe54daf62ffa61 Gerrit-Change-Number: 37139 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged