Attention is currently required from: fixeria, laforge.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email )

Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication ......................................................................

Patch Set 3:

(4 comments)

Patchset:

PS1:

we should test the specific behaviour we expect from our osmo-sgsn implementation. […]

I have made the change optional. The default behavior isn't changed.

File sgsn/BSSGP_ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/de77ab1f_234b0... : PS3, Line 333:

one tab, not two

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/f5ab0365_04f08... : PS3, Line 694: setverdict(pass);

so we don't expect service accept, but still we `setverdict(pass)`?

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/c21743ca_9335e... : PS3, Line 760: GSUP SAI Req

`GMM Auth Req`

Done