Attention is currently required from: fixeria, laforge.
lynxis lazus has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email )
Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect
authentication
......................................................................
Patch Set 3:
(4 comments)
Patchset:
PS1:
we should test the specific behaviour we expect from
our osmo-sgsn implementation. […]
I have made the change optional. The default
behavior isn't changed.
File sgsn/BSSGP_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/de77ab1f_234b…
:
PS3, Line 333:
one tab, not two
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/f5ab0365_04f0…
:
PS3, Line 694: setverdict(pass);
so we don't expect service accept, but still we
`setverdict(pass)`?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/c21743ca_9335…
:
PS3, Line 760: GSUP SAI Req
`GMM Auth Req`
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058
Gerrit-Change-Number: 38396
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Nov 2024 16:26:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>