Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30994 ) Change subject: layer23: Introduce tun.{c,h} ...................................................................... Patch Set 5: (19 comments) File src/host/layer23/include/osmocom/bb/common/tun.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/4a8afc1f_b93cc2fb PS5, Line 39: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/775cd2d5_6d44e762 PS5, Line 39: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/71c7215a_b42beb30 PS5, Line 53: int (*cb_ind) (struct tun_t * tun, void *pack, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/92199383_9fa808c1 PS5, Line 53: int (*cb_ind) (struct tun_t * tun, void *pack, Unnecessary space before function pointer arguments File src/host/layer23/src/common/tun.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/a6231ea6_20e15f84 PS5, Line 48: #elif defined (__FreeBSD__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/b3de3dea_39df748b PS5, Line 53: #elif defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/ed5fcd65_7ba99531 PS5, Line 65: #define SYS_ERR(sub, pri, en, fmt, args...) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/d0672de6_06b7e72e PS5, Line 104: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/f5b25576_d09e507d PS5, Line 123: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/26a9409c_7e36fdf1 PS5, Line 186: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/471bf806_9355b96d PS5, Line 214: strcpy(ifr.ifr_name, dev_name); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/6e9eb573_37dc9c7b PS5, Line 221: strncpy((*tun)->devname, ifr.ifr_name, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/15f4d77d_fd68634f PS5, Line 229: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/b10b6205_a672c748 PS5, Line 230: strncpy((*tun)->devname, dev_name, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/4e9f57a6_07a540c4 PS5, Line 243: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/d1d4e1e9_601e7a14 PS5, Line 273: strncpy(areq.ifra_name, (*tun)->devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/3b156a88_b929cdb2 PS5, Line 283: while (ioctl(fd, SIOCDIFADDR, (void *)&areq) != -1) ; space prohibited before semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/7efece6a_597698a6 PS5, Line 319: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2822): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/51cb1e57_8460edd6 PS5, Line 319: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len)) Unnecessary space before function pointer arguments -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id8611b720ada17a3c602872fe095bb91eeb17bcd Gerrit-Change-Number: 30994 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 19:18:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment