Attention is currently required from: Hoernchen, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 4: (408 comments) File Transceiver52M/ms/bladerf_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4fbe3d1_0d9f0738 PS4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49642581_07ec61e8 PS4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b866c7d3_5749d330 PS4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/464ad5c1_3a9c5f9c PS4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e9fcc2aa_b0cc1718 PS4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b0eae803_df27e1f2 PS4, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b0e89890_7bc88a8f PS4, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f8db839_96e8defc PS4, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9d49fcb8_79d9fad3 PS4, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b90d1efd_eac5a697 PS4, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dcd54475_204ec63a PS4, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/673d5810_1854b34d PS4, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2637fb62_819fdb80 PS4, Line 52: template <class R, class... Args> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0e2d93f9_94094f60 PS4, Line 52: template <class R, class... Args> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbf092c1_55b156a7 PS4, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3238be6b_f92ce5a1 PS4, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5bdf4196_e805fa3f PS4, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/348b6ff5_24db686a PS4, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f87d21e0_5ad7bbbe PS4, Line 57: if (rval != 0) { suspect code indent for conditional statements (8, 26) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bd533151_2135cc71 PS4, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':' labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f129fd2_a317c458 PS4, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__) __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23f561f1_dc96be17 PS4, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7ddecf5_eab95877 PS4, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a400ec35_fdb602d4 PS4, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72b8c62b_643c86bb PS4, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5678d0e_02a58d50 PS4, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/07135060_7c58bc1c PS4, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6551fd6d_a61e4b5e PS4, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/252478cc_32608f52 PS4, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a75b036c_fec16dc4 PS4, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dacfb9da_be469f57 PS4, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d3ad476_6bbdc0f4 PS4, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e121d65_ede6b47d PS4, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4e004635_9b602e43 PS4, Line 83: int actual_samples_per_msg() Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c62e3311_edc46120 PS4, Line 83: int actual_samples_per_msg() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f3cae76e_abc1f194 PS4, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0714f8ec_b83bb5d4 PS4, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0332ac93_0a1caab4 PS4, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35248f58_830d1c9b PS4, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/398d2899_244d6ff4 PS4, Line 87: int actual_samples_per_buffer() Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f73b704_6d863e79 PS4, Line 87: int actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7b7dd993_bc6945ea PS4, Line 91: int samples_per_buffer() Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea513452_0ec389d9 PS4, Line 91: int samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6c4815c_f9316241 PS4, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8100dbab_ce9c08fa PS4, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bd9d75e_51615d55 PS4, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/94683692_6b34f318 PS4, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/988c50b6_782a2bdb PS4, Line 95: int num_msgs_per_buffer() Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f23760a6_9d41eb73 PS4, Line 95: int num_msgs_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f2e0076_b9319256 PS4, Line 99: auto get_first_ts() Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5569e490_61b3ab8a PS4, Line 99: auto get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9e44604_f87c8dd7 PS4, Line 103: constexpr auto *getsampleoffset(int ofs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9cd08604_4cddb0ed PS4, Line 109: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ead71ee3_d284a5ee PS4, Line 118: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dad25988_36d68148 PS4, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23a4f2ad_20211ec3 PS4, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fe1c094a_114536d7 PS4, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5cc2f7a9_58994f42 PS4, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d3cae54_92efef6c PS4, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e85c4c12_3c187667 PS4, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/48e07691_399e4aa7 PS4, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/228b7e04_5bb66dfe PS4, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa02c71b_650b5b34 PS4, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1375b381_8daddac0 PS4, Line 185: template <typename T> struct blade_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/33646ba1_ceefb28b PS4, Line 185: template <typename T> struct blade_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f7425543_2a44f835 PS4, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23c78a22_94298175 PS4, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fb909010_285bac9d PS4, Line 202: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1625c65_d52d4e7d PS4, Line 223: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1815a0bc_a8462679 PS4, Line 223: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e6efef2d_c3fb5e09 PS4, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60a1a9ed_4895e0c3 PS4, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6141f6c2_4913ce59 PS4, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e0807d26_b764a788 PS4, Line 250: std::cerr << "open failed, device missing?" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/47f88011_ecea9030 PS4, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/105845e8_0d7716ed PS4, Line 271: std::cerr << "unable to lock refclk!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a039c05_06ba381f PS4, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fc3ca55_aa64da27 PS4, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8b23312_413ef22b PS4, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/143ab462_3c8cd39b PS4, Line 316: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/96545469_ee9ad298 PS4, Line 318: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b9038d1_c62bd61d PS4, Line 320: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9853127_cbcc8222 PS4, Line 323: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e9a0ba8a_f5a1f9da PS4, Line 325: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0573b829_f96790a1 PS4, Line 327: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/986a12ee_6fef211c PS4, Line 330: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e8325665_72308c03 PS4, Line 335: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eeaf98ed_c577c2c8 PS4, Line 338: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5631c143_e4babd92 PS4, Line 340: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b4883c42_9b20210d PS4, Line 343: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/283694a8_967c5af2 PS4, Line 346: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0bbaec33_e3230bca PS4, Line 348: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/77865371_870c1aae PS4, Line 351: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63113973_f50dbb75 PS4, Line 356: static void check_timestamp(dev_buf_t *rcd) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35facc8a_f549b0e3 PS4, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) { suspect code indent for conditional statements (16, 34) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c988091_cdc9de15 PS4, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " " labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/36b2a704_9648b2ba PS4, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9d9763eb_cc42bf17 PS4, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a3a7c73d_c4c4aa55 PS4, Line 377: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/50d09f42_43be1638 PS4, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0b515c8f_766ab88b PS4, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8dd460a_89e0c889 PS4, Line 397: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb38a84e_5de0b01d PS4, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0ffb85e2_80d22efa PS4, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db199f79_764dd8ea PS4, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/764d4f7f_071636a1 PS4, Line 410: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc1a6719_7ce1655e PS4, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a826018_257abfe5 PS4, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f848075_b5db0624 PS4, Line 422: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a406c7f1_48dd215d PS4, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/22c1ef4f_cdb239c3 PS4, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/430080b3_5020d8ab PS4, Line 435: //get empty bufer from list 'bufer' may be misspelled - perhaps 'buffer'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/13e5105f_5f1b48d5 PS4, Line 436: tx_buf_q_type::elem_t rcd; labels should not be indented File Transceiver52M/ms/ipc_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/012eb27e_9828a68d PS4, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/67aa7e2c_10d0af2e PS4, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83f56ccf_540ba082 PS4, Line 45: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d8dee05_9211c458 PS4, Line 45: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e48f9258_7dcbb966 PS4, Line 49: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f2ef3e5_199df7cf PS4, Line 49: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/29a8477f_5c79132e PS4, Line 53: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b5bd36a8_8ec23adf PS4, Line 58: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/89fff5a4_3e2d7c08 PS4, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d8a7656_2fd4712a PS4, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cb125f12_44de0e07 PS4, Line 71: template <typename T> struct ipc_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c5a255d1_bd5bbf77 PS4, Line 71: template <typename T> struct ipc_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cadb0c40_448f5f44 PS4, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58aae964_0b18c3ff PS4, Line 76: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bdb19b4_e4dabc79 PS4, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/36a3cd74_98f51df2 PS4, Line 76: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f167cd7_f20ddbca PS4, Line 92: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/363fd994_46598945 PS4, Line 99: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b275091a_aff5566d PS4, Line 106: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8ccc41d_9f198391 PS4, Line 111: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d64a6609_587150fd PS4, Line 119: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/36042a9f_51447c87 PS4, Line 127: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dec7eb5d_3584fce5 PS4, Line 132: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/93efede9_ffe77510 PS4, Line 137: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/30284523_8d782d09 PS4, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5a94372_33ed9d4c PS4, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1293d271_53f47f2a PS4, Line 164: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b1d297ee_7e504fe0 PS4, Line 166: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a33ca87_4c5d9f2e PS4, Line 175: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5c43df5_67a5db35 PS4, Line 177: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d43452d_27fb5d21 PS4, Line 183: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b838241d_12e71cc2 PS4, Line 188: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a4f7e097_0b9fe1ab PS4, Line 193: void signal_start() Bad function definition - void signal_start() should probably be void signal_start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/860d9a64_d2c0b06a PS4, Line 193: void signal_start() open brace '{' following function definitions go on the next line File Transceiver52M/ms/itrq.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a0923c2_1b823e7b PS4, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/932f2975_1867398c PS4, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99081c48_17b764f4 PS4, Line 52: std::condition_variable cond_r, cond_w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e252952d_38f043a1 PS4, Line 53: std::mutex lr, lw; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d34bb523_51332e0c PS4, Line 54: std::atomic_int r_flag, w_flag; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/faaa0581_7090fb61 PS4, Line 56: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca6c865a_0bb4aae9 PS4, Line 57: explicit spsc_cond_detail() : r_flag(0), w_flag(0) Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/965ba94c_09032b43 PS4, Line 65: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0558065d_1767f27a PS4, Line 65: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f48eaa8_fce369ae PS4, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a444b097_b5923383 PS4, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/33289b64_d73fafe5 PS4, Line 67: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18a4d521_0a45641c PS4, Line 73: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/563954a6_d9820948 PS4, Line 73: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/61b51df2_408e596d PS4, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2d4c8aba_aebf1763 PS4, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8339bc3_d5353885 PS4, Line 75: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e3675e0_b88198ec PS4, Line 81: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7882480e_ebb217f7 PS4, Line 81: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a23ebff_a512d7db PS4, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d84d3f53_31189a5f PS4, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/85e7cfdf_db9894bb PS4, Line 83: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9569393_ef87dddd PS4, Line 87: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37a410e8_9d951f13 PS4, Line 87: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/59ec3afa_82bc146c PS4, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/234f6e66_7d4b9969 PS4, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b380731b_bb4374ef PS4, Line 89: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/afb1b0f2_b5222af3 PS4, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03d9ffcd_f5ecd359 PS4, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ce546c82_b14e1f6c PS4, Line 99: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7488991a_4dea578a PS4, Line 100: explicit spsc_efd_detail() Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e1c4e612_b4d7b724 PS4, Line 111: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66f47105_647c00fb PS4, Line 111: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/56711eb9_dd44dac2 PS4, Line 116: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5457774d_30ea42cc PS4, Line 116: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/20170785_ae7ca8bf PS4, Line 121: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b301bd1f_c6046e14 PS4, Line 121: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af5ffa1c_d067749e PS4, Line 126: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d4cc88c8_8567eeba PS4, Line 126: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a56d12bc_d2c436cf PS4, Line 131: int get_r_efd() Bad function definition - int get_r_efd() should probably be int get_r_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f05949be_50034ba0 PS4, Line 131: int get_r_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7417c894_faf4de9a PS4, Line 135: int get_w_efd() Bad function definition - int get_w_efd() should probably be int get_w_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5465e245_f05ec879 PS4, Line 135: int get_w_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7e12560_47a64221 PS4, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5483259c_a5cf7729 PS4, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8bdf9b28_04ca0a1c PS4, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/48eef795_4a365bf7 PS4, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c3c7ed0_626ff455 PS4, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c97d2a9_d87a7edb PS4, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f74079e1_cf84e3a6 PS4, Line 144: std::atomic<unsigned int> readptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/498fa507_c1850fbd PS4, Line 144: std::atomic<unsigned int> readptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5f6df7e_319925ee PS4, Line 144: std::atomic<unsigned int> readptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/70e9692f_055c4a7d PS4, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/039b2282_1e9e80f4 PS4, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e39b20e1_b7ad0d0d PS4, Line 145: std::atomic<unsigned int> writeptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/29dde0de_a8fd6910 PS4, Line 149: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cccf0e07_96094b81 PS4, Line 150: using base_t = T<block_read, block_write>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/56a6883c_f25b9a95 PS4, Line 150: using base_t = T<block_read, block_write>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/604cbddb_13524c6f PS4, Line 152: explicit spsc() : readptr(0), writeptr(0) Bad function definition - explicit spsc() should probably be explicit spsc(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7577ea2_7fae4b5e PS4, Line 163: bool spsc_push(const ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7b4b8d8a_ef042a8d PS4, Line 170: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b62c39cd_8e85ef02 PS4, Line 176: base_t::spsc_notify_r(); /* fine after release */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b5047f52_41461dea PS4, Line 183: bool spsc_pop(ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1991f800_32822b22 PS4, Line 195: base_t::spsc_notify_w(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58feac33_8c9a94df PS4, Line 202: ssize_t spsc_prep_pop() Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c2bf332_919b66a6 PS4, Line 202: ssize_t spsc_prep_pop() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d5381ad_98236070 PS4, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d34cb61_c600f721 PS4, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e5b2631_91de41ba PS4, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/22ef33ae_c657ea5c PS4, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/84e478ec_33ea3544 PS4, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6130c64f_7ca6b792 PS4, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4253c014_57facb05 PS4, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; adding a line without newline at end of file Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bcd0724_1ce7d607 PS4, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bc6524ba_0e7de2a0 PS4, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '>' (ctx:VxW) File Transceiver52M/ms/logging.cpp: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a8fcf85_a2b08870 PS4, Line 83: .enabled = 0, trailing whitespace File Transceiver52M/ms/ms.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/92c4d93b_a13d4592 PS4, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b3555bd_9cb0dacd PS4, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df403a2f_f04dc1da PS4, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/136aa062_04a11670 PS4, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/746a2841_54f6371e PS4, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea27b54f_c5e4b519 PS4, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/334480fb_9a2258e8 PS4, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/219d9af0_4745c322 PS4, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f02b120a_75956860 PS4, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa7508a4_2b0a07a1 PS4, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4e0b5c93_68f7adf4 PS4, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ae4b94bb_d514ceac PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54bdc554_610c14ec PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cfa4955b_127d1999 PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a5c56a0_2e0fe28f PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b174c065_890337fb PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f90e74e0_3aa23517 PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea8bcffc_2dfc9026 PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1367311c_2e814d29 PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63d26a38_95b53f4d PS4, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2d78e9bb_304a634a PS4, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f750f316_c84111b6 PS4, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff18c897_0e44b039 PS4, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a880da7d_e71f4341 PS4, Line 75: GSM::Time gsmts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0ab49a15_a2f64398 PS4, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f39b5da2_e40bd394 PS4, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6c6fa4cd_d6b2e9f4 PS4, Line 87: std::ostream null_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f5d9aca_3682f2c6 PS4, Line 89: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8985bb81_38c409b3 PS4, Line 90: dummylog() : null_stream(this){}; space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a055764f_a81a8509 PS4, Line 92: std::ostream &operator()() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7f043ff_4566380b PS4, Line 92: std::ostream &operator()() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e774949b_c4b04f11 PS4, Line 104: GSM::Time global_time_keeper; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0cfa136_e5634a2b PS4, Line 106: std::mutex m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/33d5f41f_1f91fbe8 PS4, Line 108: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9644af96_87b9b7c7 PS4, Line 113: void set(GSM::Time t, int64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/582d4cd1_68b34f8f PS4, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/45a4262a_4ea8d352 PS4, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0052cc0f_70336e0f PS4, Line 115: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d37448f_4bce3dbe PS4, Line 119: void inc_both() Bad function definition - void inc_both() should probably be void inc_both(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/10c2312c_a51ba08a PS4, Line 119: void inc_both() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7bf103d7_b7c0ccbf PS4, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbb79027_2f021127 PS4, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8f6cf25_a00c5486 PS4, Line 121: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fffd56fd_de309817 PS4, Line 125: void inc_and_update(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/43a3d6d8_8ed45925 PS4, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/302871f5_42afa40a PS4, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4187f74e_9dd02053 PS4, Line 127: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c363c11f_0e192b5d PS4, Line 132: void inc_and_update_safe(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75888cf0_896420d4 PS4, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df7f4e7a_7057f208 PS4, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60dc5b49_21f81f99 PS4, Line 134: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80000da7_fc59f9d5 PS4, Line 142: void dec_by_one() Bad function definition - void dec_by_one() should probably be void dec_by_one(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ead67dbb_4f39a2d3 PS4, Line 142: void dec_by_one() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4c89aa24_b97adf03 PS4, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5614c6f1_1c873bba PS4, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d4aef9e3_a81f56a3 PS4, Line 144: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca19cabc_3e1a7f0a PS4, Line 148: auto get_ts() Bad function definition - auto get_ts() should probably be auto get_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eccc46e7_8ac8b3f0 PS4, Line 148: auto get_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b525391b_98386d2a PS4, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/450f37e7_44054efe PS4, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a1d3b62_1a48975d PS4, Line 150: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/392c0c6f_82a7a8e7 PS4, Line 153: auto gsmtime() Bad function definition - auto gsmtime() should probably be auto gsmtime(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9cb40f8_fbf92b4e PS4, Line 153: auto gsmtime() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cfb0e0c3_c45fa299 PS4, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bc4fea31_19c9f68b PS4, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/57bbd756_7328eeb9 PS4, Line 155: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d79ed7fb_571590ce PS4, Line 158: void get_both(GSM::Time *t, int64_t *ts) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1dac4eeb_a369dd88 PS4, Line 158: void get_both(GSM::Time *t, int64_t *ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1488fb25_324aaf2a PS4, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c91b0151_5a73d1b7 PS4, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f15aef69_34ad9179 PS4, Line 160: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/108bfb86_cccac2c7 PS4, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/30bc0907_aeb53021 PS4, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ae0e1721_21c97aed PS4, Line 176: std::thread rx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b4376944_3bcafadc PS4, Line 177: std::thread tx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc1086ea_5b58ae78 PS4, Line 178: std::thread *calcrval_task; need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81309834_9289f8b2 PS4, Line 178: std::thread *calcrval_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75da6e39_788f160e PS4, Line 189: std::atomic<bool> rcv_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/870a73bb_f61a426b PS4, Line 189: std::atomic<bool> rcv_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31842f2f_47f5808b PS4, Line 189: std::atomic<bool> rcv_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0c29eec6_6b8634df PS4, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/202d6e47_8cbe50d8 PS4, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63f32876_05191f89 PS4, Line 190: std::atomic<bool> sch_thread_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8ddb3eb_6cf2a823 PS4, Line 197: void start(); Bad function definition - void start() should probably be void start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6eb1a3b5_2423f8c2 PS4, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f2b92a5_dc50b79a PS4, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ed13e737_92be18eb PS4, Line 198: std::atomic<bool> upper_is_ready; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2fc27bb1_7332acfd PS4, Line 201: bool handle_sch_or_nb(); Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/47f53459_a4445732 PS4, Line 207: int init_device(); Bad function definition - int init_device() should probably be int init_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d2fbc01_e3865830 PS4, Line 208: int init_dev_and_streams(); Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b3d19e1_d3ca1eb7 PS4, Line 209: void stop_threads(); Bad function definition - void stop_threads() should probably be void stop_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2eb57e97_1d65ce2a PS4, Line 211: void *tx_cb(); Bad function definition - void *tx_cb() should probably be void *tx_cb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6ca641ff_aedffe2f PS4, Line 212: void maybe_update_gain(one_burst &brst); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/57707337_b57c36f8 PS4, Line 225: bh_fn_t rx_bh(); Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e373074_851dcdf3 PS4, Line 226: bh_fn_t tx_bh(); Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d314657_a327cd42 PS4, Line 229: void set_ta(int val) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5662384_406d10e4 PS4, Line 235: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8f8e78a_bcd275c4 PS4, Line 240: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype, open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ad5f97d5_7098d80d PS4, Line 252: std::cerr << name << " affinity: errreur! " << std::strerror(errno); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/da8d97c2_04d47572 PS4, Line 260: std::cerr << name << " sched: errreur! " << std::strerror(errno); labels should not be indented File Transceiver52M/ms/ms_rx_burst.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bf6bc36b_86a3f20e PS4, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale); adding a line without newline at end of file File Transceiver52M/ms/ms_upper.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/90f8d2c9_1b27d209 PS4, Line 44: bool driveControl(); Bad function definition - bool driveControl() should probably be bool driveControl(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cbcfab5d_739eeb40 PS4, Line 45: void driveReceiveFIFO(); Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/096f4076_1875a61d PS4, Line 46: void driveTx(); Bad function definition - void driveTx() should probably be void driveTx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/143c09c8_be62241c PS4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/85857abe_76b371c3 PS4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8216a6a2_bdaf2f5a PS4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7844069d_363aa08e PS4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/981f4c38_67ebda0e PS4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f88bd0bd_e708762b PS4, Line 50: std::thread thr_control, thr_rx, thr_tx; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca6d5b58_b96ba933 PS4, Line 52: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dd69099d_b33a248d PS4, Line 53: void start_threads(); Bad function definition - void start_threads() should probably be void start_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ad30313_13ee267b PS4, Line 54: void start_lower_ms(); Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e806a26_3d47e93c PS4, Line 56: upper_trx(){}; space required before the open brace '{' File Transceiver52M/ms/sch.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8919dc75_78a49634 PS4, Line 130: int gsm_fcch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a0038a8_7b7becc0 PS4, Line 134: int gsm_sch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bfe8f1eb_d02b27ec PS4, Line 205: #if 1 Consider removing the #if 1 and its #endif Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8383c1e_5905f49f PS4, Line 210: float a, b, c, d, ang, avg = 0.0f; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3aa84301_a70d654c PS4, Line 235: ang = b - a; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/702ddc3c_c1f2c84b PS4, Line 237: if (ang > M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb6d9f7b_3d1e23d9 PS4, Line 238: ang -= 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eba55abe_a7f27444 PS4, Line 239: else if (ang < -M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75c89e05_3398e884 PS4, Line 240: ang += 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/589cc63a_42137108 PS4, Line 242: avg += ang; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/407e9cc7_97614d20 PS4, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f2e9dd1_309b5ac3 PS4, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/572dfcd8_6eb64dbd PS4, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0bad2ad0_d42845ab PS4, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9a50d475_2bbfcf48 PS4, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6cfa77bf_bf9cf38a PS4, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b599d44e_55c6adb2 PS4, Line 314: static __attribute__((constructor)) void init() Bad function definition - void init() should probably be void init(void) File Transceiver52M/ms/uhd_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7b95643_49719c96 PS4, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1546e22b_8b53a493 PS4, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/706d54eb_86c0cfe4 PS4, Line 41: uhd::rx_metadata_t *md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b563b4dc_5b7ba6c8 PS4, Line 43: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f6c6497_875f0ef3 PS4, Line 43: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/309b0818_a4faab71 PS4, Line 47: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/225b0d2b_6288c7a0 PS4, Line 47: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/68f0e848_0ed7f80b PS4, Line 51: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4476c175_2765e0c7 PS4, Line 56: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f983f62f_c4d28670 PS4, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e17fede8_2c4ee921 PS4, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2215ac88_13f089c4 PS4, Line 69: template <typename T> struct uhd_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d30102c2_bdcb967f PS4, Line 69: template <typename T> struct uhd_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0c96334b_f663c05d PS4, Line 70: uhd::usrp::multi_usrp::sptr dev; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e8bfadc6_90e82626 PS4, Line 71: uhd::rx_streamer::sptr rx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/964c9ccc_af1df233 PS4, Line 72: uhd::tx_streamer::sptr tx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d81c4884_b27050af PS4, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/92f90106_90b1dbb1 PS4, Line 74: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dd1a0b5c_a92e64b7 PS4, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2d7f5c6c_5f46808d PS4, Line 74: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4187062d_8821effe PS4, Line 90: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f69c36a_bee628bf PS4, Line 90: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/929845ba_73446dab PS4, Line 95: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6fc061ff_83703c9e PS4, Line 102: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d187f6de_9d9bb43b PS4, Line 109: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/62e3837a_0ee9cfc9 PS4, Line 114: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9888dce8_4e6ef144 PS4, Line 122: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e916fc1a_4ccc7816 PS4, Line 130: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/13d9d6a3_13bb68c0 PS4, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/90dd63fe_76543117 PS4, Line 145: std::string args = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/750a55ee_bc163bea PS4, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/492fbf42_0306e4a8 PS4, Line 153: uhd::tune_request_t tune_request(freq, 0); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cba3bd7d_f0593e7f PS4, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms)); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ce5a8ecb_f91ec7d2 PS4, Line 164: uhd::stream_args_t stream_args("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3102800_201fe8c0 PS4, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/64f67bf6_764a5bce PS4, Line 177: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d55f2fe_b88d6f98 PS4, Line 182: uhd::rx_metadata_t md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d093052_b73d29ef PS4, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/032baf98_744a75a3 PS4, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df0faf8c_754cffc2 PS4, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror()); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2447c177_849f468f PS4, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eaef6c1c_64c29ae9 PS4, Line 211: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4761d444_31eca120 PS4, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba8b1b42_6569e1e4 PS4, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/145336ee_cfe770e1 PS4, Line 227: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d59a9b9_90e94ae8 PS4, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1eb7354f_545176b7 PS4, Line 234: uhd::tx_metadata_t m = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fb6cce9d_ea898f7d PS4, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8e9dab80_6ee037c4 PS4, Line 239: std::vector<void *> ptrs(1, buffer); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3e2bb41_a10a728a PS4, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/21b7ba3e_e2719417 PS4, Line 239: std::vector<void *> ptrs(1, buffer); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9641279f_94d130cf PS4, Line 243: uhd::async_metadata_t async_md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e278f517_40fee58e PS4, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78f6461d_4ba31637 PS4, Line 251: }; adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 01 Dec 2022 14:39:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment