Attention is currently required from: Hoernchen, pespin.
408 comments:
File Transceiver52M/ms/bladerf_specific.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '&&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '&&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 44: out << '(' << std::forward<Arg>(arg);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 44: out << '(' << std::forward<Arg>(arg);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... };
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... };
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...);
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...);
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 52: template <class R, class... Args>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 52: template <class R, class... Args>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line,
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 56: R rval = func(std::forward<Args>(args)...);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 56: R rval = func(std::forward<Args>(args)...);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 57: if (rval != 0) {
suspect code indent for conditional statements (8, 26)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':'
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__)
__func__ should be used instead of gcc specific __FUNCTION__
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 69: using blade_sample_type = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 69: using blade_sample_type = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!");
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!");
spaces required around that '>' (ctx:VxB)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!");
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!");
spaces required around that '>' (ctx:VxB)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 82: blade_usb_message<T> m[SZ];
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 82: blade_usb_message<T> m[SZ];
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 83: int actual_samples_per_msg()
Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 83: int actual_samples_per_msg()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 87: int actual_samples_per_buffer()
Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 87: int actual_samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 91: int samples_per_buffer()
Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 91: int samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxB)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 95: int num_msgs_per_buffer()
Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 95: int num_msgs_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 99: auto get_first_ts()
Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 99: auto get_first_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 103: constexpr auto *getsampleoffset(int ofs)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 109: int readall(blade_sample_type *outaddr)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 118: int read_n(blade_sample_type *outaddr, int start, int num)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 178: static blade_otw_buffer<SZ / 512, T> x;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 178: static blade_otw_buffer<SZ / 512, T> x;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 185: template <typename T> struct blade_hw {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 185: template <typename T> struct blade_hw {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 202: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 223: void close_device()
Bad function definition - void close_device() should probably be void close_device(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 223: void close_device()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual;
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 250: std::cerr << "open failed, device missing?" << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 271: std::cerr << "unable to lock refclk!" << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples);
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 316: bool tuneTx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 318: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 320: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 323: bool tuneRx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 325: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 327: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 330: bool tuneRxOffset(double offset, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 335: double setRxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 338: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 340: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 343: double setTxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 346: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 348: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 351: int setPowerAttenuation(int atten, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 356: static void check_timestamp(dev_buf_t *rcd)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) {
suspect code indent for conditional statements (16, 34)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " "
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta,
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 377: void *samples, size_t num_samples, void *user_data) -> void * {
spaces prohibited around that '->' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta,
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 397: void *samples, size_t num_samples, void *user_data) -> void * {
spaces prohibited around that '->' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 410: auto fn = [this] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 422: auto fn = [this] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 435: //get empty bufer from list
'bufer' may be misspelled - perhaps 'buffer'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 436: tx_buf_q_type::elem_t rcd;
labels should not be indented
File Transceiver52M/ms/ipc_specific.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 38: using blade_sample_type = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 38: using blade_sample_type = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 45: auto actual_samples_per_buffer()
Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 45: auto actual_samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 49: long get_first_ts()
Bad function definition - long get_first_ts() should probably be long get_first_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 49: long get_first_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 53: int readall(blade_sample_type *outaddr)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 58: int read_n(blade_sample_type *outaddr, int start, int num)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 71: template <typename T> struct ipc_hw {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 71: template <typename T> struct ipc_hw {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 92: bool tuneTx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 99: bool tuneRx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 106: bool tuneRxOffset(double offset, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 111: double setRxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 119: double setTxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 127: int setPowerAttenuation(int atten, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 132: int init_device(bh_fn_t rxh, bh_fn_t txh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 137: void *rx_cb(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf };
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf };
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 164: auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 166: auto fn = [this, burst_handler] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 175: auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 177: auto fn = [] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 183: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 188: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 193: void signal_start()
Bad function definition - void signal_start() should probably be void signal_start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 193: void signal_start()
open brace '{' following function definitions go on the next line
File Transceiver52M/ms/itrq.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 52: std::condition_variable cond_r, cond_w;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 53: std::mutex lr, lw;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 54: std::atomic_int r_flag, w_flag;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 56: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 57: explicit spsc_cond_detail() : r_flag(0), w_flag(0)
Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 65: ssize_t spsc_check_r()
Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 65: ssize_t spsc_check_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 67: std::unique_lock<std::mutex> lk(lr);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 67: std::unique_lock<std::mutex> lk(lr);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 67: std::unique_lock<std::mutex> lk(lr);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 73: ssize_t spsc_check_w()
Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 73: ssize_t spsc_check_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 75: std::unique_lock<std::mutex> lk(lw);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 75: std::unique_lock<std::mutex> lk(lw);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 75: std::unique_lock<std::mutex> lk(lw);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 81: void spsc_notify_r()
Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 81: void spsc_notify_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 83: std::unique_lock<std::mutex> lk(lr);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 83: std::unique_lock<std::mutex> lk(lr);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 83: std::unique_lock<std::mutex> lk(lr);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 87: void spsc_notify_w()
Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 87: void spsc_notify_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 89: std::unique_lock<std::mutex> lk(lw);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 89: std::unique_lock<std::mutex> lk(lw);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 89: std::unique_lock<std::mutex> lk(lw);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 99: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 100: explicit spsc_efd_detail()
Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 111: ssize_t spsc_check_r()
Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 111: ssize_t spsc_check_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 116: ssize_t spsc_check_w()
Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 116: ssize_t spsc_check_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 121: void spsc_notify_r()
Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 121: void spsc_notify_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 126: void spsc_notify_w()
Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 126: void spsc_notify_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 131: int get_r_efd()
Bad function definition - int get_r_efd() should probably be int get_r_efd(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 131: int get_r_efd()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 135: int get_w_efd()
Bad function definition - int get_w_efd() should probably be int get_w_efd(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 135: int get_w_efd()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 142: class spsc : public T<block_read, block_write> {
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 142: class spsc : public T<block_read, block_write> {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 144: std::atomic<unsigned int> readptr;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 144: std::atomic<unsigned int> readptr;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 144: std::atomic<unsigned int> readptr;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 145: std::atomic<unsigned int> writeptr;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 145: std::atomic<unsigned int> writeptr;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 145: std::atomic<unsigned int> writeptr;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 149: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 150: using base_t = T<block_read, block_write>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 150: using base_t = T<block_read, block_write>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 152: explicit spsc() : readptr(0), writeptr(0)
Bad function definition - explicit spsc() should probably be explicit spsc(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 163: bool spsc_push(const ELEM *elem)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 170: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 176: base_t::spsc_notify_r(); /* fine after release */
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 183: bool spsc_pop(ELEM *elem)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 195: base_t::spsc_notify_w();
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 202: ssize_t spsc_prep_pop()
Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 202: ssize_t spsc_prep_pop()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {};
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {};
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {};
adding a line without newline at end of file
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {};
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {};
spaces required around that '>' (ctx:VxW)
File Transceiver52M/ms/logging.cpp:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 83: .enabled = 0,
trailing whitespace
File Transceiver52M/ms/ms.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 34: #define BASET blade_hw<ms_trx>
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 34: #define BASET blade_hw<ms_trx>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 37: #define BASET uhd_hw<ms_trx>
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 37: #define BASET uhd_hw<ms_trx>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 40: #define BASET ipc_hw<ms_trx>
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 40: #define BASET ipc_hw<ms_trx>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max)
need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 60: template <typename DST_T, typename SRC_T, typename ST>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 60: template <typename DST_T, typename SRC_T, typename ST>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 75: GSM::Time gsmts;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 87: std::ostream null_stream;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 89: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 90: dummylog() : null_stream(this){};
space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 92: std::ostream &operator()()
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 92: std::ostream &operator()()
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 104: GSM::Time global_time_keeper;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 106: std::mutex m;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 108: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 113: void set(GSM::Time t, int64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 115: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 115: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 115: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 119: void inc_both()
Bad function definition - void inc_both() should probably be void inc_both(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 119: void inc_both()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 121: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 121: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 121: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 125: void inc_and_update(int64_t new_ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 127: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 127: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 127: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 132: void inc_and_update_safe(int64_t new_ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 134: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 134: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 134: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 142: void dec_by_one()
Bad function definition - void dec_by_one() should probably be void dec_by_one(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 142: void dec_by_one()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 144: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 144: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 144: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 148: auto get_ts()
Bad function definition - auto get_ts() should probably be auto get_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 148: auto get_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 150: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 150: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 150: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 153: auto gsmtime()
Bad function definition - auto gsmtime() should probably be auto gsmtime(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 153: auto gsmtime()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 155: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 155: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 155: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 158: void get_both(GSM::Time *t, int64_t *ts)
need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 158: void get_both(GSM::Time *t, int64_t *ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 160: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 160: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 160: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 176: std::thread rx_task;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 177: std::thread tx_task;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 178: std::thread *calcrval_task;
need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 178: std::thread *calcrval_task;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 189: std::atomic<bool> rcv_done;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 189: std::atomic<bool> rcv_done;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 189: std::atomic<bool> rcv_done;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 190: std::atomic<bool> sch_thread_done;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 190: std::atomic<bool> sch_thread_done;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 190: std::atomic<bool> sch_thread_done;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 197: void start();
Bad function definition - void start() should probably be void start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 198: std::atomic<bool> upper_is_ready;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 198: std::atomic<bool> upper_is_ready;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 198: std::atomic<bool> upper_is_ready;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 201: bool handle_sch_or_nb();
Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 207: int init_device();
Bad function definition - int init_device() should probably be int init_device(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 208: int init_dev_and_streams();
Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 209: void stop_threads();
Bad function definition - void stop_threads() should probably be void stop_threads(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 211: void *tx_cb();
Bad function definition - void *tx_cb() should probably be void *tx_cb(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 212: void maybe_update_gain(one_burst &brst);
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 225: bh_fn_t rx_bh();
Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 226: bh_fn_t tx_bh();
Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 229: void set_ta(int val)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 235: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 240: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype,
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 252: std::cerr << name << " affinity: errreur! " << std::strerror(errno);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 260: std::cerr << name << " sched: errreur! " << std::strerror(errno);
labels should not be indented
File Transceiver52M/ms/ms_rx_burst.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale);
adding a line without newline at end of file
File Transceiver52M/ms/ms_upper.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 44: bool driveControl();
Bad function definition - bool driveControl() should probably be bool driveControl(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 45: void driveReceiveFIFO();
Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 46: void driveTx();
Bad function definition - void driveTx() should probably be void driveTx(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
function definition argument 'int' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
function definition argument 'int' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 50: std::thread thr_control, thr_rx, thr_tx;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 52: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 53: void start_threads();
Bad function definition - void start_threads() should probably be void start_threads(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 54: void start_lower_ms();
Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 56: upper_trx(){};
space required before the open brace '{'
File Transceiver52M/ms/sch.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 130: int gsm_fcch_check_ts(int ts, int fn) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 134: int gsm_sch_check_ts(int ts, int fn) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 205: #if 1
Consider removing the #if 1 and its #endif
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 210: float a, b, c, d, ang, avg = 0.0f;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 235: ang = b - a;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 237: if (ang > M_PI)
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 238: ang -= 2 * M_PI;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 239: else if (ang < -M_PI)
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 240: ang += 2 * M_PI;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 242: avg += ang;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) {
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 314: static __attribute__((constructor)) void init()
Bad function definition - void init() should probably be void init(void)
File Transceiver52M/ms/uhd_specific.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 35: using blade_sample_type = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 35: using blade_sample_type = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 41: uhd::rx_metadata_t *md;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 43: auto actual_samples_per_buffer()
Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 43: auto actual_samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 47: long get_first_ts()
Bad function definition - long get_first_ts() should probably be long get_first_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 47: long get_first_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 51: int readall(blade_sample_type *outaddr)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 56: int read_n(blade_sample_type *outaddr, int start, int num)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 69: template <typename T> struct uhd_hw {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 69: template <typename T> struct uhd_hw {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 70: uhd::usrp::multi_usrp::sptr dev;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 71: uhd::rx_streamer::sptr rx_stream;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 72: uhd::tx_streamer::sptr tx_stream;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 90: void close_device()
Bad function definition - void close_device() should probably be void close_device(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 90: void close_device()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 95: bool tuneTx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 102: bool tuneRx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 109: bool tuneRxOffset(double offset, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 114: double setRxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 122: double setTxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 130: int setPowerAttenuation(int atten, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 145: std::string args = {};
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 153: uhd::tune_request_t tune_request(freq, 0);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms));
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 164: uhd::stream_args_t stream_args("sc16", "sc16");
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16");
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 177: void *rx_cb(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 182: uhd::rx_metadata_t md;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror());
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 211: auto fn = [this, burst_handler] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 227: auto fn = [] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 234: uhd::tx_metadata_t m = {};
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 239: std::vector<void *> ptrs(1, buffer);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 239: std::vector<void *> ptrs(1, buffer);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 239: std::vector<void *> ptrs(1, buffer);
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 239: std::vector<void *> ptrs(1, buffer);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 243: uhd::async_metadata_t async_md;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
Patch Set #4, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517):
adding a line without newline at end of file
To view, visit change 30416. To unsubscribe, or for help writing mail filters, visit settings.