Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040?usp=email )
Change subject: s1gw: send the actual Recovery Time Stamp
......................................................................
Patch Set 3:
(1 comment)
File s1gw/S1GW_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040/comment/e70ed715_07d9…
:
PS1, Line 242: f_pfcp_get_recovery_timestamp()));
It probably makes more sense to pass this value as a
param of f_pfcp_handle_assoc_setup_req(), so th […]
Done, see
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38098. I don't think it's a big
problem that each `ConnHdlr` requests the recovery timestamp after spawning, since
it's basically just fetching a value.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I350d28289526d8264ef9b70e796ef76ee7fcbb4b
Gerrit-Change-Number: 38040
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Sep 2024 17:52:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>