Attention is currently required from: pespin.

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35232?usp=email )

Change subject: socket: Reimplement osmo_sock_init2_multiaddr() ......................................................................

Patch Set 2:

(1 comment)

File src/core/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/35232/comment/97f6d9df_6d77f3dc PS2, Line 945: (loc_has_v4addr != rem_has_v4addr || loc_has_v6addr != rem_has_v6addr)) {

the if condition looks right, but is IMHO a bit hard to read, maybe move it / or the whole block her […]

with multiple return paths I mean, to potentially make it more readable