Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30950 )
Change subject: layer23: Add VTY supports for l23_apps ......................................................................
Patch Set 1:
(2 comments)
File src/host/layer23/src/common/main.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/0ea8aa82_b4a1bb65 PS1, Line 271: handle_options
I may be missing something, but I believe option parsing, config parsing, and setting up the VTY sho […]
It doesn't take VTY config anyway. It's chicken an egg problem we have in all apps. The idea anyway is that l23_app_info() mostly initializes memory, but doesn't "open" stuff which may be prone to errors, etc. that will be done in new l23_app_start() API, which is called after cmdline and VTY parsing.
https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/f0d79599_f806c3c8 PS1, Line 331: talloc_free(config_file
This looks wrong to me. […]
Ack