Attention is currently required from: jolly, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32930 ) Change subject: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions ...................................................................... Patch Set 1: Code-Review-1 (3 comments) File include/osmocom/gsm/protocol/gsm_44_068.h: https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/390285fe_aa935f5f PS1, Line 19: enum gcc_iei { missing osmo_ prefix in all definitions, in order to keep everything in the same namespace. (yes, I know old code in libosmocore doesn't do it). https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/fad2f37d_739a3e61 PS1, Line 123: Ack File src/gsm/gsm44068.c: https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/bc86e110_f0b2b020 PS1, Line 22: const struct value_string gcc_msg_type_names[] = { osmo_* and OSMO_* prefix missing everywhere. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32930 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3554cea47e714c8fca18c3e9c0e6e80695915a90 Gerrit-Change-Number: 32930 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 15:08:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment