Attention is currently required from: jolly, dexter.

Patch set 1:Code-Review -1

View Change

3 comments:

• File include/osmocom/gsm/protocol/gsm_44_068.h:

  • Patch Set #1, Line 19: enum gcc_iei {

    missing osmo_ prefix in all definitions, in order to keep everything in the same namespace. (yes, I know old code in libosmocore doesn't do it).

  • Patch Set #1, Line 123:

    we usually add a an inline function that returns the name using get_value_string for convenience. […]

    Ack

• File src/gsm/gsm44068.c:

  • Patch Set #1, Line 22: const struct value_string gcc_msg_type_names[] = {

    osmo_* and OSMO_* prefix missing everywhere.

To view, visit change 32930. To unsubscribe, or for help writing mail filters, visit settings.