[M] Change in osmo-e1d[master]: Add option to automatically reset RIFO on underrun/overflow - gerrit-log

14 Jan 2024

Attention is currently required from: laforge, manawyrm, pespin, tnt.

jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1d/+/34554?usp=email )

Change subject: Add option to automatically reset RIFO on underrun/overflow
......................................................................

Patch Set 4:

(4 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/f7be57bf_25d48c4e 
PS1, Line 7: Automatically reset RIFO on underrun/overflow
...
  Maybe I need to split this commit. It is the work I
have done. Check it out and do some comments. Due to rework, not required anymore.

Patchset:

PS3: 
...
  RX Buffer fill: 0-----50%D-----D-----150%D […]
The process is reworked.

File src/octoi/e1oip.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/605e2b5d_951a5069 
PS3, Line 274: 			iline_ctr_add(iline, LINE_CTR_E1oIP_E1T_OVERFLOW, 1);
...
  I'm a bit worried that we do this after the first
packet with out of range frame nr. […] Done

File src/octoi/octoi_srv_vty.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/3209f46c_97439da3 
PS3, Line 419: void set_frames_per_fifo_str(void)
...
  why do we have those runtime generated strings?
can't we generate them at compile time? We're passin […] Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/34554?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Id7ccbfbdb288990c01f185dec79a1022a68b4748
Gerrit-Change-Number: 34554
Gerrit-PatchSet: 4
Gerrit-Owner: jolly &lt;andreas(a)eversberg.eu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: manawyrm &lt;osmocom.account(a)tbspace.de&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Reviewer: tnt &lt;tnt(a)246tNt.com&gt;
Gerrit-Attention: manawyrm &lt;osmocom.account(a)tbspace.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: tnt &lt;tnt(a)246tNt.com&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Sun, 14 Jan 2024 15:19:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly &lt;andreas(a)eversberg.eu&gt;
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-MessageType: comment