[L] Change in osmo-msc[master]: [codecs filter] send + receive SDP via MNCC - gerrit-log

14 Mar 2023

Attention is currently required from: pespin.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31698
)

Change subject: [codecs filter] send + receive SDP via MNCC
......................................................................

Patch Set 6:

(4 comments)

File src/libmsc/gsm_04_08_cc.c:

https://gerrit.osmocom.org/c/osmo-msc/+/31698/comment/ae3bdbf0_1b8411fd 
PS3, Line 633: 	codec_filter_run(&trans->cc.codecs);
...
  You are already calling codec_filter_run in line 621,
why calling this again here? Ack

https://gerrit.osmocom.org/c/osmo-msc/+/31698/comment/422c99d4_9edaac54 
PS3, Line 935: 	codec_filter_run(&trans->cc.codecs);
...
  as usual, why is filter_run called here? is
new_cc_state() changing it? just calling _run() before using the result, in the log
line just below this.
Some code paths may change the codecs filter elements, e.g. setting the assignment result.
The paradigm is to call run() before using the result.

https://gerrit.osmocom.org/c/osmo-msc/+/31698/comment/5415fdcd_7bab7efd 
PS3, Line 973: 		codec_filter_run(&trans->cc.codecs);
...
  in here it makes sense to call _run() because you are
calling set_remote() before? Or actually it ha […] Yes, the codecs filter may change
from _set_remote() because the remote codecs are now known / may have changed.

But the main point is calling _run() before using the result just below this

https://gerrit.osmocom.org/c/osmo-msc/+/31698/comment/ca57336c_655386f6 
PS3, Line 1084: 	codec_filter_run(&trans->cc.codecs);
...
  same ehre, why is all full of codec_filter_run?
because in the line just below this, the result is sent as SDP to the remote call
leg via MNCC.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31698
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie0668c0e079ec69da1532b52d00621efe114fc2c
Gerrit-Change-Number: 31698
Gerrit-PatchSet: 6
Gerrit-Owner: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Tue, 14 Mar 2023 22:52:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-MessageType: comment