Attention is currently required from: pespin.

View Change

4 comments:

• File src/libmsc/gsm_04_08_cc.c:

  • Patch Set #3, Line 633: codec_filter_run(&trans->cc.codecs);

    You are already calling codec_filter_run in line 621, why calling this again here?

    Ack

  • Patch Set #3, Line 935: codec_filter_run(&trans->cc.codecs);

    as usual, why is filter_run called here? is new_cc_state() changing it?

    just calling _run() before using the result, in the log line just below this.
    Some code paths may change the codecs filter elements, e.g. setting the assignment result. The paradigm is to call run() before using the result.

  • Patch Set #3, Line 973: codec_filter_run(&trans->cc.codecs);

    in here it makes sense to call _run() because you are calling set_remote() before? Or actually it ha […]

    Yes, the codecs filter may change from _set_remote() because the remote codecs are now known / may have changed.

    But the main point is calling _run() before using the result just below this

  • Patch Set #3, Line 1084: codec_filter_run(&trans->cc.codecs);

    same ehre, why is all full of codec_filter_run?

    because in the line just below this, the result is sent as SDP to the remote call leg via MNCC.

To view, visit change 31698. To unsubscribe, or for help writing mail filters, visit settings.