Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30813 ) Change subject: tests/llc: Test gprs_llc_is_retransmit() ...................................................................... Patch Set 1: (9 comments) File tests/llc/llc_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/5ba18c04_9b2e92dd PS1, Line 29: #define ASSERT_FALSE(x) if (x) { printf("Should have returned false.\n"); abort(); } Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/75a28e8f_348e2432 PS1, Line 30: #define ASSERT_TRUE(x) if (!x) { printf("Should have returned true.\n"); abort(); } Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/845cc372_090b4051 PS1, Line 48: ASSERT_TRUE (nu_is_retransmission(0, 1)); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/c4309079_bef56ec7 PS1, Line 51: ASSERT_TRUE (nu_is_retransmission(0, 1)); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/fba044ac_c19607db PS1, Line 52: ASSERT_TRUE (nu_is_retransmission(511, 1)); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/230dc13a_050408a8 PS1, Line 53: ASSERT_TRUE (nu_is_retransmission(483, 1)); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/cf0f30d9_f9b30b3b PS1, Line 54: ASSERT_TRUE (nu_is_retransmission(482, 1)); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/784378ab_43ac3427 PS1, Line 62: ASSERT_TRUE (nu_is_retransmission(510, 511)); // behind space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/de454c9c_e8ccf652 PS1, Line 63: ASSERT_TRUE (nu_is_retransmission(481, 511)); // behind space prohibited between function name and open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I4104ee9cc458b7d169ee9761e02369442058675a Gerrit-Change-Number: 30813 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 02 Jan 2023 12:25:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment