9 comments:
File tests/llc/llc_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317):
Patch Set #1, Line 29: #define ASSERT_FALSE(x) if (x) { printf("Should have returned false.\n"); abort(); }
Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317):
Patch Set #1, Line 30: #define ASSERT_TRUE(x) if (!x) { printf("Should have returned true.\n"); abort(); }
Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317):
Patch Set #1, Line 48: ASSERT_TRUE (nu_is_retransmission(0, 1));
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317):
Patch Set #1, Line 51: ASSERT_TRUE (nu_is_retransmission(0, 1));
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317):
Patch Set #1, Line 52: ASSERT_TRUE (nu_is_retransmission(511, 1));
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317):
Patch Set #1, Line 53: ASSERT_TRUE (nu_is_retransmission(483, 1));
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317):
Patch Set #1, Line 54: ASSERT_TRUE (nu_is_retransmission(482, 1));
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317):
Patch Set #1, Line 62: ASSERT_TRUE (nu_is_retransmission(510, 511)); // behind
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317):
Patch Set #1, Line 63: ASSERT_TRUE (nu_is_retransmission(481, 511)); // behind
space prohibited between function name and open parenthesis '('
To view, visit change 30813. To unsubscribe, or for help writing mail filters, visit settings.