Attention is currently required from: clufn, fixeria.
pespin has posted comments on this change by clufn. (
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277?usp=email )
Change subject: Enable the use of an UE requested IP type and address to be used for gtpv2
PDN Address Allocation
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
File src/epdg_ue_fsm.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277/comment/731f8db7_228e…
:
PS3, Line 264: lager:info("ue_fsm state_new event=auth_request {~p, ~p, ~p},
~p~n", [PdpTypeNr, PdpAddress, Apn, EAP, Data]),
you are missing a ~p here now afaict, and in all same lines you are modifying below.
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: If0c77b1e366df36439d3a1b72030d831dd1b3a05
Gerrit-Change-Number: 40277
Gerrit-PatchSet: 3
Gerrit-Owner: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Comment-Date: Mon, 12 May 2025 10:41:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes