Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920?usp=email ) Change subject: s1gw: Add initial PFCP support emulating UPF ...................................................................... Patch Set 2: (3 comments) File s1gw/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920/comment/4ed63c0f_28b1… : PS2, Line 185: float Tval := 5.0 Because sometimes the timeouts were too tight, specially when creating tons of sessions where then also ttcn3 has to answer to them. It is also easier to debug if some time is left between the error and the tear down, one can see in the pcap the seconds clearly. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920/comment/c6fef19a_49d0… : PS2, Line 269: do_repeat := true only once, but since it's an activate, it has to be a repeat otherwise when code goes into whatever alt, if this message is received then it will skip the alt unexpectedly. File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920/comment/a28d2780_1654… : PS2, Line 81: id) alive alive: I can put it into another patch id: I'm simply refactoring code since anyway i need to add a lot of infra when adding the pfcp side. TBH I don't think it's worth spending time in splitting this at this time of the development of this testsuite where lots of stuff is still missing and may change / be rewritten when more features are added. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2b135e113d2568092e90ac9b6c5f651ab30f5d0 Gerrit-Change-Number: 37920 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Aug 2024 22:43:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>