Attention is currently required from: fixeria.

View Change

3 comments:

• File s1gw/ConnHdlr.ttcn:

  • Patch Set #2, Line 185: float Tval := 5.0

    This looks unrelated. […]

    Because sometimes the timeouts were too tight, specially when creating tons of sessions where then also ttcn3 has to answer to them.
    It is also easier to debug if some time is left between the error and the tear down, one can see in the pcap the seconds clearly.

  • Patch Set #2, Line 269: do_repeat := true

    Do we normally expect receiving the Assoc Setup Req more than once? […]

    only once, but since it's an activate, it has to be a repeat otherwise when code goes into whatever alt, if this message is received then it will skip the alt unexpectedly.

• File s1gw/S1GW_Tests.ttcn:

  • Patch Set #2, Line 81: id) alive

    These changes looks unrelated to me: […]

    alive: I can put it into another patch
    id: I'm simply refactoring code since anyway i need to add a lot of infra when adding the pfcp side.

    TBH I don't think it's worth spending time in splitting this at this time of the development of this testsuite where lots of stuff is still missing and may change / be rewritten when more features are added.

To view, visit change 37920. To unsubscribe, or for help writing mail filters, visit settings.