Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30962 ) Change subject: layer23: fix integer overflow in l1ctl_tx_data_req() ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/common/l1ctl.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30962/comment/5f52a462_1bb708bd PS1, Line 397: chan_ts, gsmtap_chan_type, chan_ss, 0, 127, 0, Because it's Tx data (Uplink), so there cannot be Signal-Noise-Ratio. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I23e9ea5ad59099c24db60057c8e7da1e6a0d2293 Gerrit-Change-Number: 30962 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 07:19:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment