Jenkins Builder has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38139?usp=email ) Change subject: tests: add unit tests for trau2rtp conversion, FR & EFR ...................................................................... Patch Set 1: (8 comments) File tests/trau_conv/trau16_to_rtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18528): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/9d5fdd6b_c5280a88… : PS1, Line 196: /* The only valid 1-byte payload is TEH by itself 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18528): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/78d545e5_1709b5ad… : PS1, Line 200: printf(" TW-TS-001 TEH octet: 0x%02X\n", rtp_pl[0]); 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18528): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/cdbefaff_8b5d0ee7… : PS1, Line 213: printf(" TW-TS-001 TEH octet: 0x%02X\n", rtp_pl[0]); 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18528): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/46e5b4f4_37bce879… : PS1, Line 250: /* The only valid 1-byte payload is TEH by itself 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18528): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/6374e059_71a1d33a… : PS1, Line 254: printf(" TW-TS-001 TEH octet: 0x%02X\n", rtp_pl[0]); 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18528): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/66b8955b_833fc730… : PS1, Line 267: printf(" TW-TS-001 TEH octet: 0x%02X\n", rtp_pl[0]); 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18528): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/b7a1096d_f23a191a… : PS1, Line 326: default: switch default: should use break Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18528): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/58257b4d_a9c7f6b3… : PS1, Line 377: if (argc != 4) { suspect code indent for conditional statements (8, 24) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie319900125baa8f20595cac83343771d780a5b4e Gerrit-Change-Number: 38139 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sat, 14 Sep 2024 07:29:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No