Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31572 )
Change subject: modem: route L1CTL prims to/from libosmo-gprs-rlcmac ......................................................................
Patch Set 1:
(1 comment)
File src/host/layer23/src/modem/rlcmac.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31572/comment/f5cab026_e6d0747c PS1, Line 173: rlcmac_prim_l1ctl_alloc
Nothing really prevents you from filling the struct with a designated initializer like you are doing […]
... the need to pass dummy arguments to `osmo_gprs_rlcmac_prim_alloc_l1ctl_pdch_data_ind()` which will then be overwritten by designated initializer. I can go for that, but I really like this approach.
-
fixeria