Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30119 ) Change subject: [codecs filter] MO call: apply BSS codec list ...................................................................... Patch Set 1: (1 comment) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/30119/comment/a62a9ec2_5736118d PS1, Line 619: codec_filter_run(&trans->cc.codecs); i first wanted to run it implicitly whenever any of the input information changes, so that it always reflects an accurate result. but that doesn't make sense when we're going to place N inputs directly one after another, so i put the "run" in a separately called function. what you say is true, but running the filter is cheap, and i'd rather err on running it too often. (possibly this makes more sense after some later patches, but i'm not perfectly sure. i'm busy breaking down a code bomb into readable pieces... and it is taking way too long, so i hope that this is fine with you, certainly not harmful) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30119 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I062268406ae3f3a63a7f413db51c509c9eaf9e8a Gerrit-Change-Number: 30119 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Nov 2022 22:55:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment