Attention is currently required from: pespin.

View Change

1 comment:

• File src/libmsc/gsm_04_08_cc.c:

  • Patch Set #1, Line 619: codec_filter_run(&trans->cc.codecs);

    Why running it now instead of waiting to do so when you need to retrieve the result? […]

    i first wanted to run it implicitly whenever any of the input information changes, so that it always reflects an accurate result.
    but that doesn't make sense when we're going to place N inputs directly one after another, so i put the "run" in a separately called function.

    what you say is true, but running the filter is cheap, and i'd rather err on running it too often. (possibly this makes more sense after some later patches, but i'm not perfectly sure. i'm busy breaking down a code bomb into readable pieces... and it is taking way too long, so i hope that this is fine with you, certainly not harmful)

To view, visit change 30119. To unsubscribe, or for help writing mail filters, visit settings.