Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30935 ) Change subject: libosmogsm: Add osmo_io support to ipa ...................................................................... Patch Set 3: (3 comments) Patchset: PS3: If those empty functions still need to be filled, the patch should be marked as WIP File include/osmocom/gsm/ipa.h: https://gerrit.osmocom.org/c/libosmocore/+/30935/comment/67134f02_64728a87 PS3, Line 60: ipa_ccm_send_pong_iofd do we really want to expose even more of those low-level functions into the global namespace? The point of osmo_io is to achieve a higher level of abstraction, so nobody except the I/O framework should ever want to use those low-level functions anymore. Also, in general I think the new high-level IPA-on-osmo_io should all be in libosmocore so programs that don't do anything abis/trau/e1 related don't need to depend on libosmo-abis. File src/gsm/ipa.c: https://gerrit.osmocom.org/c/libosmocore/+/30935/comment/2cb358d6_e007c895 PS3, Line 814: v what is the purpose of those empty functions here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0f955d5a36afe7a08d31b8ba4185260362c2bcca Gerrit-Change-Number: 30935 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:27:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment