Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40436?usp=email ) Change subject: gsn: fix coding style issue ...................................................................... Patch Set 1: (27 comments) File gtp/gsn.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/4abf3f64_0949cd98?us… : PS1, Line 166: int (*cb)(struct sockaddr_in * peer)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/d82733e7_7a565165?us… : PS1, Line 173: int (*cb)(struct sockaddr_in * peer)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/3fc34f22_bf9005c4?us… : PS1, Line 180: int (*cb)(struct sockaddr_in * peer, union gtpie_member **ie)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/2889a956_9bd563b7?us… : PS1, Line 188: int gtp_set_cb_delete_context(struct gsn_t *gsn, int (*cb)(struct pdp_t * pdp)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/dd4ef6dc_07603fdd?us… : PS1, Line 196: struct pdp_t * pdp, void *cbp)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/4028e080_11b35779?us… : PS1, Line 203: int (*cb)(struct sockaddr_in * peer, uint8_t recovery)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/210a142a_606838ec?us… : PS1, Line 217: int (*cb_recovery2)(struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/fc4ea374_4954b053?us… : PS1, Line 218: struct pdp_t * pdp, uint8_t recovery)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/b38ce751_8c69bfdd?us… : PS1, Line 240: int (*cb_data_ind)(struct pdp_t * pdp, "foo * bar" should be "foo *bar" File include/osmocom/gtp/gsn.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/d818d9f6_786a28b2?us… : PS1, Line 100: int (*cb_delete_context)(struct pdp_t *); function definition argument 'struct pdp_t *' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/471e2576_054ff27f?us… : PS1, Line 101: int (*cb_create_context_ind)(struct pdp_t *); function definition argument 'struct pdp_t *' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/b21d5539_b56fd72a?us… : PS1, Line 103: int (*cb_unsup_ind)(struct sockaddr_in * peer); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/34459c95_57a5fc62?us… : PS1, Line 104: int (*cb_extheader_ind)(struct sockaddr_in * peer); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/b0b8a3e6_7c80dfd2?us… : PS1, Line 106: int (*cb_conf)(int type, int cause, struct pdp_t * pdp, void *cbp); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/65a56e84_96a2cf70?us… : PS1, Line 107: int (*cb_data_ind)(struct pdp_t * pdp, void *pack, unsigned len); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/dbc9c802_b30a83a7?us… : PS1, Line 108: int (*cb_recovery)(struct sockaddr_in * peer, uint8_t recovery); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/444f081c_32a0fa4b?us… : PS1, Line 109: int (*cb_recovery2)(struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/8693f336_26b27853?us… : PS1, Line 109: int (*cb_recovery2)(struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/27ee80e7_b5aa5978?us… : PS1, Line 141: int (*cb_data_ind)(struct pdp_t * pdp, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/f0770205_c73a95a6?us… : PS1, Line 150: int (*cb)(struct sockaddr_in * peer)); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/0ba00e4e_24a6f6f0?us… : PS1, Line 153: int (*cb)(struct sockaddr_in * peer)); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/f45cabcb_7f11d65c?us… : PS1, Line 156: int (*cb)(struct sockaddr_in * peer, union gtpie_member **ie)); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/ac9de58f_56d139b1?us… : PS1, Line 159: int (*cb)(int type, int cause, struct pdp_t * pdp, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/7f4aa15b_e0ece7a2?us… : PS1, Line 163: int (*cb)(struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/2a0bb09f_4140379c?us… : PS1, Line 167: int (*cb)(struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/96920312_af5bc823?us… : PS1, Line 172: int (*cb)(struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40436/comment/73f86326_07f570ff?us… : PS1, Line 172: int (*cb)(struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar" -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40436?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1d978ed32619b626e82aa70887ac94b82c4de378 Gerrit-Change-Number: 40436 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 04 Jun 2025 16:51:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No