View Change

27 comments:

• File gtp/gsn.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 166: int (*cb)(struct sockaddr_in * peer))

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 173: int (*cb)(struct sockaddr_in * peer))

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 180: int (*cb)(struct sockaddr_in * peer, union gtpie_member **ie))

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 188: int gtp_set_cb_delete_context(struct gsn_t *gsn, int (*cb)(struct pdp_t * pdp))

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 196: struct pdp_t * pdp, void *cbp))

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 203: int (*cb)(struct sockaddr_in * peer, uint8_t recovery))

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 217: int (*cb_recovery2)(struct sockaddr_in * peer,

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 218: struct pdp_t * pdp, uint8_t recovery))

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 240: int (*cb_data_ind)(struct pdp_t * pdp,

    "foo * bar" should be "foo *bar"

• File include/osmocom/gtp/gsn.h:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 100: int (*cb_delete_context)(struct pdp_t *);

    function definition argument 'struct pdp_t *' should also have an identifier name

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 101: int (*cb_create_context_ind)(struct pdp_t *);

    function definition argument 'struct pdp_t *' should also have an identifier name

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 103: int (*cb_unsup_ind)(struct sockaddr_in * peer);

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 104: int (*cb_extheader_ind)(struct sockaddr_in * peer);

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 106: int (*cb_conf)(int type, int cause, struct pdp_t * pdp, void *cbp);

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 107: int (*cb_data_ind)(struct pdp_t * pdp, void *pack, unsigned len);

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 108: int (*cb_recovery)(struct sockaddr_in * peer, uint8_t recovery);

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 109: int (*cb_recovery2)(struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery);

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 109: int (*cb_recovery2)(struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery);

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 141: int (*cb_data_ind)(struct pdp_t * pdp,

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 150: int (*cb)(struct sockaddr_in * peer));

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 153: int (*cb)(struct sockaddr_in * peer));

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 156: int (*cb)(struct sockaddr_in * peer, union gtpie_member **ie));

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 159: int (*cb)(int type, int cause, struct pdp_t * pdp,

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 163: int (*cb)(struct sockaddr_in * peer,

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 167: int (*cb)(struct sockaddr_in * peer,

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 172: int (*cb)(struct gsn_t * gsn, struct sockaddr_in * peer,

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 172: int (*cb)(struct gsn_t * gsn, struct sockaddr_in * peer,

    "foo * bar" should be "foo *bar"

To view, visit change 40436. To unsubscribe, or for help writing mail filters, visit settings.