Attention is currently required from: osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28002
)
Change subject: paging: Take into account extra delay of all paging groups in BSC queue
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc/paging.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28002/comment/c415e8c9_80b749a9
PS2, Line 671: GSM51_MFRAME_DURATION_us
is dividing GSM51_MFRAME_DURATION_us by n_pag_blocks
intentional?
Yes. we can send n_pag_block requests every GSM51_MFRAME_DURATION_us
microseconds, so we do the following relation:
npag_block/GSM51_MFRAME_DURATION_us = 1/time_us;
time_us = 1*GSM51_MFRAME_DURATION_us/npag_block;
That means we can send 1 paging req every GSM51_MFRAME_DURATION_us/n_pag_block.
The (n_pag_blocks - 1) part is to do the integer ceiling of the resulting division.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28002
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib55f947c5d3490b27e1d08d39392992919512f9a
Gerrit-Change-Number: 28002
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 03 May 2022 08:39:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment