Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38047?usp=email ) Change subject: pySim.commands: use _checksw during get_data() method ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Patchset: PS3: I have checked back the spec, the status word in the successful case is 9000, so everything looks correct. File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/38047/comment/35250192_52cc1886?usp=em… : PS3, Line 798: data, sw = self.send_apdu_checksw('%02xca%04x00' % (cla, tag)) maybe put a spec ref on top of the method? Something like: GPC_SPE_034 11.3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic784bf0c30b22e5e83843aa6694e2706b4b2ac48 Gerrit-Change-Number: 38047 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 Sep 2024 14:50:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes