Attention is currently required from: falconia. Jenkins Builder has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38139?usp=email ) Change subject: tests: add unit tests for trau2rtp conversion, FR & EFR ...................................................................... Patch Set 2: (6 comments) File tests/trau_conv/trau16_to_rtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18530): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/17ff3df0_bbd28759… : PS2, Line 196: /* The only valid 1-byte payload is TEH by itself 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18530): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/62b7b07b_b3c0f542… : PS2, Line 200: printf(" TW-TS-001 TEH octet: 0x%02X\n", rtp_pl[0]); 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18530): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/7b15e122_0efaf453… : PS2, Line 213: printf(" TW-TS-001 TEH octet: 0x%02X\n", rtp_pl[0]); 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18530): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/39632be1_2c1b962f… : PS2, Line 250: /* The only valid 1-byte payload is TEH by itself 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18530): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/33f41c57_5d7177cb… : PS2, Line 254: printf(" TW-TS-001 TEH octet: 0x%02X\n", rtp_pl[0]); 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18530): https://gerrit.osmocom.org/c/libosmo-abis/+/38139/comment/20ba6fa1_45bae8a5… : PS2, Line 267: printf(" TW-TS-001 TEH octet: 0x%02X\n", rtp_pl[0]); 'TEH' may be misspelled - perhaps 'THE'? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie319900125baa8f20595cac83343771d780a5b4e Gerrit-Change-Number: 38139 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sat, 14 Sep 2024 07:42:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No