Change in osmo-ci[master]: lint: ignore STATIC_CONST_CHAR_ARRAY - gerrit-log

22 Sep 2022

Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29448
)

Change subject: lint: ignore STATIC_CONST_CHAR_ARRAY
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1: 
The reason would be what Vadim wrote in the referenced patch,

...
  const * const - "should" does not mean must.
It's a unit test, and I don't really care whether the test vectors end up in
RODATA. It would actually be the first time for me using 'const * const', I
don't remember anybody strictly requiring this during code review. 
So it seems like we don't care about it. Or do we?

In general I try to adjust the linter so that when it fails then most likely something is
wrong that really needs to be fixed, rather than failing more often with things that might
be wrong but oftentimes we don't care about it (like max line length).

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29448
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I09eecd9382842293ab231eb9cc92756fbe7723c1
Gerrit-Change-Number: 29448
Gerrit-PatchSet: 1
Gerrit-Owner: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Thu, 22 Sep 2022 13:14:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-MessageType: comment