Attention is currently required from: pespin.
1 comment:
Patchset:
The reason would be what Vadim wrote in the referenced patch,
const * const - "should" does not mean must. It's a unit test, and I don't really care whether the test vectors end up in RODATA. It would actually be the first time for me using 'const * const', I don't remember anybody strictly requiring this during code review.
So it seems like we don't care about it. Or do we?
In general I try to adjust the linter so that when it fails then most likely something is wrong that really needs to be fixed, rather than failing more often with things that might be wrong but oftentimes we don't care about it (like max line length).
To view, visit change 29448. To unsubscribe, or for help writing mail filters, visit settings.