Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33201 ) Change subject: stream: Add IPA send function/IPA-mode read to srv ...................................................................... Patch Set 1: (3 comments) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/8dffe91a_2056f1e2 PS1, Line 632: SRV why SRV? isn't it CLI_OR_INP or something like that? https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/e7542ad7_700a835c PS1, Line 1952: from the msgb structure's l1 and possibly l2 headers why from the l1/l2 headers? Wouldn't it be more in-line with existign code to use something like the msgb->cb for this? In general, if there is additional information (like SCTP PPID) that the transmitting function needs to know, we pass it via msgb->cb. The actual data part should only contain things that are part of the message https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/a5d3578e_9e9a5754 PS1, Line 1959: OSMO_ASSERT below non-ipa code has OSMO_ASSERT(conn), too. Yours not. Any specific rationale? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33201 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529 Gerrit-Change-Number: 33201 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Jun 2023 09:44:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment