Attention is currently required from: arehbein.
3 comments:
File src/stream.c:
why SRV? isn't it CLI_OR_INP or something like that?
Patch Set #1, Line 1952: from the msgb structure's l1 and possibly l2 headers
why from the l1/l2 headers? Wouldn't it be more in-line with existign code to use something like the msgb->cb for this?
In general, if there is additional information (like SCTP PPID) that the transmitting function needs to know, we pass it via msgb->cb. The actual data part should only contain things that are part of the message
Patch Set #1, Line 1959: OSMO_ASSERT
below non-ipa code has OSMO_ASSERT(conn), too. Yours not. Any specific rationale?
To view, visit change 33201. To unsubscribe, or for help writing mail filters, visit settings.