Attention is currently required from: laforge, pespin, fixeria.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32561 )
Change subject: vty: show bug in implicit go_parent_node
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/32561/comment/93f51fd2_cde9277b
PS1, Line 26: there is no legacy vty_go_parent() function that sets the correct
: index via a switch().
yes, for example in cs7 config, the go_parent_cb()
does the action of applying config changes. […]
Done
File tests/vty/vty_transcript_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/32561/comment/8cc41617_94b64364
PS1, Line 344: talloc_asprintf(root_ctx, argv[0]);
yes, seems i wasn't paying attention, thx
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32561
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2472daed7436a1947655b06d34eb217e595bc7f3
Gerrit-Change-Number: 32561
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 May 2023 16:12:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment