Attention is currently required from: osmith, pespin.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email )
Change subject: jenkins-common: Treat -asan builds the same as -master
......................................................................
Patch Set 2:
(1 comment)
File jenkins-common.sh:
https://gerrit.osmocom.org/c/docker-playground/+/37192/comment/5e61fc8f_ef7…
PS1, Line 548: image_suffix_is_master() {
I would really name it
"osmo_repo_is_nightly", not "image_suffix_is_nightly". […]
Would
you also rename the other image_suffix_is_ functions in that case?
--
To view, visit
https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ibf93880345f38668f8dc812d1523b985d368dfcc
Gerrit-Change-Number: 37192
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jun 2024 10:55:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment