Attention is currently required from: pespin, fixeria, dexter.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/31885 )
Change subject: PCU IF: Update NSE timer field
......................................................................
Patch Set 1:
(1 comment)
File include/osmo-bts/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-bts/+/31885/comment/e643ad4c_ab571988
PS1, Line 156: PCU_IF_NUM_NSE_TIMERS
First of all and before going onto next matters: […]
I found all the 7 timers communicated in the definition of the static array
`gprs_ns_timer_strs` in libosmocore/src/gb/gprs_ns_vty.c: 55, plus an 8th timer tsns-prov.
So I thought why not add it while I'm at it.
It's been a couple of weeks but we addressed this together with Daniel/you had a chat
about it on libera and it is indeed used by the PCU (just adding this here for anyone else
reading this); and the question was do we want this to be configurable through the BSC as
well (currently it's only configurable in the PCU via vty).
Not entirely sure right now how the above mentions array in libosmocore relates to all of
this/haven't checked that.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/31885
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7385574ef4bd4529d2e7e3d2000b7a1551ef1fcb
Gerrit-Change-Number: 31885
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 07 May 2023 20:29:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment