Attention is currently required from: fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35123?usp=email )
Change subject: Add a GSM RLP decoder and encoder
......................................................................
Patch Set 3:
(6 comments)
File include/osmocom/gsm/rlp.h:
https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/de1eb2e3_a60d4538
PS2, Line 24: GSM A5 ciphering algorithm
copy-paste
Done
https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/eec7bc21_5d35b0e5
PS2, Line 28: 24.002
It should actually be TS 24.022.
Done
https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/82cb3675_f892582d
PS2, Line 75: osmo_rlp_decode
also expose `osmo_rlp_encode`?
Done
File src/gsm/libosmogsm.map:
https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/956fd7dd_284d57d2
PS2, Line 863: osmo_rlp_decode
also expose `osmo_rlp_encode`?
Done
File src/gsm/rlp.c:
https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/2dc4a088_7655f214
PS2, Line 77: EINVAL
`ENOTSUP`
Done
https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/86a9fb93_11f5c33b
PS2, Line 121: EINVAL
`ENOTSUP`
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35123?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2d9bd8eb4f0cd0f72c436996767b199429596917
Gerrit-Change-Number: 35123
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Nov 2023 18:44:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment