Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 ) Change subject: add library/PFCP_*, deps/PFCP ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Patchset: PS3: IMHO the (value|omit) template designators are mandatory. We use them everywhere, except maybe code written in the first few months of TTCN-3 usage in Osmocom, when we didn't understand them yet. File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/244062b0_ec1a… PS1, Line 18: type enumerated e_PFCP_Cause { Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/dc716423_0162… PS1, Line 418: function ts_PFCP_Session_Est_Req(charstring node_id, OCT8 cp_seid, Create_PDR_list create_pdr, Create_FAR_list create_far) return template PDU_PFCP { I agree that those annotations are a very useful tool and allow to detect a number of issues already at compile time, which otherwise are only caught at runtime (if at all). Just like the use of "const" in C, or the use of type annotations in python. There are good reasons to use them, and hence we use all of the above, in the respective language. Nobody has ever started to debate about it until this discussion here. Another way to think of it is something like "compile-time invariant checks", if that helps. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Aug 2022 09:54:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment