Attention is currently required from: neels, pespin.
Patch set 3:Code-Review -1
3 comments:
Patchset:
IMHO the (value|omit) template designators are mandatory. We use them everywhere, except maybe code written in the first few months of TTCN-3 usage in Osmocom, when we didn't understand them yet.
File library/PFCP_Templates.ttcn:
Patch Set #1, Line 18: type enumerated e_PFCP_Cause {
I thought it was in our library/ dir, then it's fine you can keep it in Templates.
Done
Patch Set #1, Line 418: function ts_PFCP_Session_Est_Req(charstring node_id, OCT8 cp_seid, Create_PDR_list create_pdr, Create_FAR_list create_far) return template PDU_PFCP {
marking as (value) means you cannot pass a template containing a field which is not set to a value, […]
I agree that those annotations are a very useful tool and allow to detect a number of issues already at compile time, which otherwise are only caught at runtime (if at all). Just like the use of "const" in C, or the use of type annotations in python.
There are good reasons to use them, and hence we use all of the above, in the respective language. Nobody has ever started to debate about it until this discussion here.
Another way to think of it is something like "compile-time invariant checks", if that helps.
To view, visit change 28817. To unsubscribe, or for help writing mail filters, visit settings.