Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28027 )
Change subject: server: Detect duplicate client/bankd connection; drop new ones ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
even it allows DDoS i would like to drop the old connection. […]
I'm not talking about rogue actors, but about an accidential misconfiguration. That's why I think it is more safe to keep the current client. If we are talking about some kind of network outage, or operating system reboot of the client and old client == new client, then the old connection will time out (we do have application level keep-alives for that). The new client will meanwhile keep trying to re-connect and once the old connection is gone, the new connection will succeed.
Overall I think this is the safer and less risky approach.