Attention is currently required from: dexter, fixeria. Hello dexter, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38175?usp=email to look at the new patch set (#2). Change subject: pySim.profile: Further refactor card <-> profile matching ...................................................................... pySim.profile: Further refactor card <-> profile matching The new architecture avoids sim/ruim/uicc specific methods in pySim.profile and instead moves the profile-specific code into the profile; it also solves everything within the class hierarchy, no need for global methods. Change-Id: I3b6c44d2f5cce2513c3ec8a3ce939a242f3e4901 --- M pySim/cdma_ruim.py M pySim/profile.py M pySim/ts_102_221.py M pySim/ts_51_011.py 4 files changed, 51 insertions(+), 56 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/75/38175/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3b6c44d2f5cce2513c3ec8a3ce939a242f3e4901 Gerrit-Change-Number: 38175 Gerrit-PatchSet: 2 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: dexter &lt;pmaier(a)sysmocom.de&gt;