Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change by laforge. (
https://gerrit.osmocom.org/c/pysim/+/38049?usp=email )
Change subject: pySim-shell: Detect different eUICC types and print during start-up
......................................................................
Patch Set 9:
(4 comments)
File pySim/euicc.py:
https://gerrit.osmocom.org/c/pysim/+/38049/comment/74de49bf_93ad6da3?usp=em… :
PS6, Line 580: -> bool:
Not addressed.
Done
https://gerrit.osmocom.org/c/pysim/+/38049/comment/59c21866_99cbc2b1?usp=em… :
PS6, Line 598: -> bool:
Not addressed.
Done
https://gerrit.osmocom.org/c/pysim/+/38049/comment/28c1b08e_af8da91d?usp=em… :
PS6, Line 616: -> bool:
Not addressed.
Done
File pySim/euicc.py:
https://gerrit.osmocom.org/c/pysim/+/38049/comment/ba0aa4d4_cee8219f?usp=em… :
PS8, Line 572: gc =
unused variable?
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/38049?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I54ea4ce663693f3951040dcc8a16bf532bf99c02
Gerrit-Change-Number: 38049
Gerrit-PatchSet: 9
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Sep 2024 16:25:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>