pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33075 )

(

1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: rlcmac: Avoid generating UL data if no data to be sent available ......................................................................

rlcmac: Avoid generating UL data if no data to be sent available

Dummy LLC commands only make sense in the network->MS direction, in order to delay closing the DL TBF (3GPP TS 44.064 6.4.2.2). That code in the MS is a leftover from porting code from osmo-pcu.

Change-Id: I062aa9aea4f7d66a70ed53eae1c67780ddc3dca5 --- M src/rlcmac/tbf_ul.c 1 file changed, 13 insertions(+), 7 deletions(-)

Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified

diff --git a/src/rlcmac/tbf_ul.c b/src/rlcmac/tbf_ul.c index 40e993c..b38c750 100644 --- a/src/rlcmac/tbf_ul.c +++ b/src/rlcmac/tbf_ul.c @@ -589,13 +589,6 @@ gprs_rlcmac_rlc_ul_window_v_a(ul_tbf->ulw)); if (restart_bsn_cycle(ul_tbf)) return take_next_bsn(ul_tbf, bi, previous_bsn, may_combine); - } else { - /* Nothing left to send, create dummy LLC commands */ - LOGPTBFUL(ul_tbf, LOGL_DEBUG, "Sending new dummy block at BSN %d, CS=%s\n", - gprs_rlcmac_rlc_ul_window_v_s(ul_tbf->ulw), - gprs_rlcmac_mcs_name(tx_cs)); - bsn = create_new_bsn(ul_tbf, bi, tx_cs); - /* Don't send a second block, so don't set cs_current_trans */ }

if (bsn < 0) {