Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31880?usp=email ) Change subject: Make NSE timing data configurable ...................................................................... Patch Set 7: (5 comments) File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/e1361416_f0442e57 PS7, Line 347: extern const size_t bts_gprs_rlc_timer_templates_bytes; why is this being removed here? it probably should be removed in the previous commit? File src/osmo-bsc/bts_init.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/73d560f5_01f82f49 PS7, Line 111: /* Init per-BTS NS timers */ it will probably help adding an extra blank line before this one. File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/49d596a6_1cb99518 PS7, Line 1662: static const struct tdef_data gprs_ns_timer_tdef_data[7] = { I'm still totally not understanding why do you need this index lookup here. If you want to keep the older indices to keep backward compatibilities, why not using those same timer names in the tdef structure? File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/3ada7b05_d99d0ee3 PS7, Line 225: g = &bts->timer_groups[OSMO_BSC_BTS_TDEF_GROUPS_RLC]; you could fix your proper commit and already use this name so you don't need to change it in the followup commit (and save my time reviewing it). File tests/gprs_params.vty: https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/f5b24ba8_fc25acc3 PS7, Line 36: gprs nsei 0 why did the timers dissappear here? because they are the default values? then ACK. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31880?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie46ec5cb7095bc1dfe3effd0e76d6ccfd6bd2f3f Gerrit-Change-Number: 31880 Gerrit-PatchSet: 7 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Dec 2023 12:03:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment