Attention is currently required from: arehbein.

View Change

5 comments:

• File include/osmocom/bsc/bts.h:

  • Patch Set #7, Line 347: extern const size_t bts_gprs_rlc_timer_templates_bytes;

    why is this being removed here? it probably should be removed in the previous commit?

• File src/osmo-bsc/bts_init.c:

  • Patch Set #7, Line 111: /* Init per-BTS NS timers */

    it will probably help adding an extra blank line before this one.

• File src/osmo-bsc/bts_vty.c:

  • Patch Set #7, Line 1662: static const struct tdef_data gprs_ns_timer_tdef_data[7] = {

    I'm still totally not understanding why do you need this index lookup here. If you want to keep the older indices to keep backward compatibilities, why not using those same timer names in the tdef structure?

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #7, Line 225: g = &bts->timer_groups[OSMO_BSC_BTS_TDEF_GROUPS_RLC];

    you could fix your proper commit and already use this name so you don't need to change it in the followup commit (and save my time reviewing it).

• File tests/gprs_params.vty:

  • Patch Set #7, Line 36: gprs nsei 0

    why did the timers dissappear here? because they are the default values? then ACK.

To view, visit change 31880. To unsubscribe, or for help writing mail filters, visit settings.