Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28628 )

Change subject: filesystem: Introduce the basic notion of 'logical channels' ......................................................................

Patch Set 3:

(1 comment)

File pySim/filesystem.py:

https://gerrit.osmocom.org/c/pysim/+/28628/comment/ff501191_084d3ee8 PS1, Line 55: if cla >> 4 in [0x0, 0xA, 0x8]: What if neither (cla >> 4) is in [0x0, 0xA, 0x8], nor (cla & 0xD0) is in [0x40, 0xC0]? I would raise a ValueError, just to be sure the function would not return None.